Merged
Conversation
Report for GZ2E01 (23bee3b - 5ff4250)📈 Matched code: 63.57% (+0.33%, +37352 bytes) ✅ 90 new matches:
...and 60 more new matches |
YunataSavior
changed the title
TakaRikka
reviewed
Jun 7, 2025
Comment on lines
+115
to
+117
| /* 80564990-805649A0 0094F0 0010+00 1/0 0/0 0/0 .text checkChangeJoint__12daNpc_Maro_cFi */ | ||
| /* 80564990 */ BOOL checkChangeJoint(int arg0) { return arg0 == 4; }; | ||
| /* 805649A0-805649B0 009500 0010+00 1/0 0/0 0/0 .text checkRemoveJoint__12daNpc_Maro_cFi */ |
Contributor
There was a problem hiding this comment.
symbol comments can be removed
Comment on lines
+232
to
+233
| 13072, 13072, 0, 12896, 13088, 13088, 13088, 13072, 13072, 13088, 13072, 13072, | ||
| 13072, 13072, 13072, 13072, 0, |
Contributor
There was a problem hiding this comment.
heap sizes are better in hex imo
Contributor
Author
There was a problem hiding this comment.
OK, that means that I'll have to modify my beautify anm data script to spit out hex values for this.
| void daNpc_Maro_c::getType() { | ||
| // NONMATCHING | ||
| u8 daNpc_Maro_c::getType() { | ||
| switch ((u8)fopAcM_GetParam(this)) { |
Contributor
There was a problem hiding this comment.
think this would look better as fopAcM_GetParam(this) & 0xFF
Contributor
Author
There was a problem hiding this comment.
Using the debug rom, turns out it looks like:
u8 param = fopAcM_GetParam(this) & 0xFF;
switch (param) {
| || 0 == strcmp(dComIfGp_getEventManager().getRunEventName(), "CONTINUE_ARROWTUTORIAL") | ||
| || 0 == strcmp(dComIfGp_getEventManager().getRunEventName(), "END_ARROWTUTORIAL") | ||
| || 0 == strcmp(dComIfGp_getEventManager().getRunEventName(), "CLEAR_ARROWTUTORIAL")) { | ||
| // |
| mDoMtx_stack_c::multVec(&my_vec_0, &my_vec_1); | ||
| mGndChk.SetPos(&my_vec_1); | ||
| my_vec_1.y = dComIfG_Bgsp().GroundCross(&mGndChk); | ||
| JUT_ASSERT(0xDA9, -(1000000000.0f) != my_vec_1.y); |
Contributor
There was a problem hiding this comment.
this assert doesnt match the debug rom afaict. make sure the variables are named the same as in debug
| } | ||
|
|
||
| if (mStagger.checkStagger() == 0) { | ||
| // mtype switch. |
Contributor
There was a problem hiding this comment.
what is this comment referring to?
Contributor
Author
There was a problem hiding this comment.
This was an incorrect stub comment that I should have deleted beforehand XD
Fixed all the issues you noted, btw.
TakaRikka
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.